From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965119AbbI2NUB (ORCPT ); Tue, 29 Sep 2015 09:20:01 -0400 Received: from www.linutronix.de ([62.245.132.108]:39606 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964945AbbI2NTy (ORCPT ); Tue, 29 Sep 2015 09:19:54 -0400 Date: Tue, 29 Sep 2015 15:19:15 +0200 (CEST) From: Thomas Gleixner To: Peter Zijlstra cc: mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com, rostedt@goodmis.org Subject: Re: [RFC][PATCH 11/11] sched: More notrace In-Reply-To: <20150929093520.692241015@infradead.org> Message-ID: References: <20150929092825.540553633@infradead.org> <20150929093520.692241015@infradead.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Peter Zijlstra wrote: > preempt_schedule_common() is marked notrace, but it does not use > _notrace() preempt_count functions and __schedule() is also not marked > notrace, which means that its perfectly possible to end up in the > tracer from preempt_schedule_common(). > > So either we need more notrace, or we need to remove notrace from > preempt_schedule_common(). More notrace is the right thing to do. We have enough pointless information in tracing already. Reviewed-by: Thomas Gleixner