From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934584AbbI2QHp (ORCPT <rfc822;w@1wt.eu>);
	Tue, 29 Sep 2015 12:07:45 -0400
Received: from www.linutronix.de ([62.245.132.108]:43326 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932168AbbI2QHh (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 29 Sep 2015 12:07:37 -0400
Date: Tue, 29 Sep 2015 18:06:59 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, jason@lakedaemon.net
Subject: Re: [PATCH v4 1/2] ARM: irqchip: mxs: prepare driver for HW with
 different offsets
In-Reply-To: <1443025230-24146-2-git-send-email-linux@rempel-privat.de>
Message-ID: <alpine.DEB.2.11.1509291804510.4500@nanos>
References: <alpine.DEB.2.11.1509221234070.5606@nanos> <1443025230-24146-1-git-send-email-linux@rempel-privat.de> <1443025230-24146-2-git-send-email-linux@rempel-privat.de>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 23 Sep 2015, Oleksij Rempel wrote:

Subject: irqchip/mxs: ..... Please

> +struct icoll_priv {
> +	void __iomem *vector;
> +	void __iomem *levelack;
> +	void __iomem *ctrl;
> +	void __iomem *stat;
> +	void __iomem *intr;
> +	/* number of interrupts per register */
> +	int intr_per_reg;

Why are you adding this here just to remove it in the next patch?

> +	void __iomem *clear;

Please do not add members which are not required for the preparatory
step.

Thanks,

	tglx