From: Thomas Gleixner <tglx@linutronix.de>
To: Qais Yousef <qais.yousef@imgtec.com>
Cc: Jiang Liu <jiang.liu@linux.intel.com>,
linux-kernel@vger.kernel.org, marc.zyngier@arm.com,
jason@lakedaemon.net, linux-mips@linux-mips.org
Subject: Re: [PATCH 4/6] irq: add a new generic IPI handling code to irq core
Date: Tue, 29 Sep 2015 18:15:49 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.11.1509291811520.4500@nanos> (raw)
In-Reply-To: <5603B3D1.3000405@imgtec.com>
On Thu, 24 Sep 2015, Qais Yousef wrote:
> The CPUs we want to send the IPI to are not Linux CPUs only. My use case is
> about sending IPI to audio coprocessor.
> So "dest" doesn't have to be part of Linux online CPUs, hence we need to
> specify it so that the underlying controller will know how to map to that CPU.
> I should have put more info in the cover letter, not just the link to the
> discussion, apologies for that.
>
> I'm not sure about cpu hotplug. We could call irq_destroy_ipi() when a cpu is
> hot unplugged, but the current behaviour is to statically reserve the IPI and
> keep them reserved. I think it makes sense to keep it this way for SMP IPIs or
> things will get complicated.
Right. For general IPIs which are destined to all Linux CPUs we keep
them reserved unless the facility which needs them is shut down.
CPU hotplug is just disabling the IPI reception on the particular
core, but does not change the reservation for e.g. the resched IPI.
> For a coprocessor, if we the 'module is unloaded', I'd expect the
> irq_destroy_ipi() to be called returning the reserved IPI to the pool.
For any case which shuts down a IPI based facility (coprocessor or
general) we want to return the IPI. Otherwise we leak the IPI on
module removal and allocate a new one on reload.
Thanks,
tglx
next prev parent reply other threads:[~2015-09-29 16:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 14:49 [PATCH 0/6] Implement generic IPI support mechanism Qais Yousef
2015-09-23 14:49 ` [PATCH 1/6] irqdomain: add new IRQ_DOMAIN_FLAGS_IPI Qais Yousef
2015-09-23 14:49 ` [PATCH 2/6] irqdomain: add a new send_ipi() to irq_domain_ops Qais Yousef
2015-09-23 16:44 ` Jiang Liu
2015-09-24 8:12 ` Qais Yousef
2015-09-23 14:49 ` [PATCH 3/6] irqdomain: add struct irq_hwcfg and helper functions Qais Yousef
2015-09-23 14:49 ` [PATCH 4/6] irq: add a new generic IPI handling code to irq core Qais Yousef
2015-09-23 16:50 ` Jiang Liu
2015-09-24 8:26 ` Qais Yousef
2015-09-29 16:15 ` Thomas Gleixner [this message]
2015-09-23 14:49 ` [PATCH 5/6] irqchip: mips-gic: add a IPI hierarchy domain Qais Yousef
2015-09-23 14:49 ` [PATCH 6/6] irqchip: mips-gic: use the new generic IPI API Qais Yousef
2015-09-23 16:54 ` [PATCH 0/6] Implement generic IPI support mechanism Jiang Liu
2015-09-24 8:39 ` Qais Yousef
2015-09-29 20:48 ` Thomas Gleixner
2015-09-30 13:34 ` Qais Yousef
2015-09-30 14:03 ` Thomas Gleixner
2015-09-30 14:08 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1509291811520.4500@nanos \
--to=tglx@linutronix.de \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=qais.yousef@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®