From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965475AbbI2SdF (ORCPT ); Tue, 29 Sep 2015 14:33:05 -0400 Received: from www.linutronix.de ([62.245.132.108]:45668 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965377AbbI2Sc4 (ORCPT ); Tue, 29 Sep 2015 14:32:56 -0400 Date: Tue, 29 Sep 2015 20:32:19 +0200 (CEST) From: Thomas Gleixner To: Mason cc: LKML , Daniel Lezcano Subject: Re: Trivial clocksource driver In-Reply-To: <560ABB95.8000404@free.fr> Message-ID: References: <560ABB95.8000404@free.fr> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Sep 2015, Mason wrote: > Hello everyone, > > I am trying to submit a new ARM port, and Arnd pointed out that the > clocksource code could not live in arch/arm/$PLATFORM, but had to > move to drivers/clocksource (and it had to support DT). > > Did I understand correctly? Is this the right place to submit code > as provided below? Yes, drivers/clocksource is the right place. You just need to submit a formal patch, which includes a proper subject line, changelog, plus the necessary Makefile and Kconfig modifications. > #include /* register_current_timer_delay */ Please get rid of these silly tail comments. They provide absolutely no value. Other than that this looks reasonable. Thanks, tglx