From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932872AbbI3Uko (ORCPT ); Wed, 30 Sep 2015 16:40:44 -0400 Received: from www.linutronix.de ([62.245.132.108]:44698 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932516AbbI3Ukm (ORCPT ); Wed, 30 Sep 2015 16:40:42 -0400 Date: Wed, 30 Sep 2015 22:39:59 +0200 (CEST) From: Thomas Gleixner To: Steven Rostedt cc: Peter Zijlstra , mingo@kernel.org, linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, fweisbec@gmail.com, oleg@redhat.com, umgwanakikbuti@gmail.com Subject: Re: [PATCH v2 01/12] sched: Simplify INIT_PREEMPT_COUNT In-Reply-To: <20150930050421.0268a360@gandalf.local.home> Message-ID: References: <20150930071035.514587432@infradead.org> <20150930072303.631400497@infradead.org> <20150930050421.0268a360@gandalf.local.home> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Sep 2015, Steven Rostedt wrote: > > /* > > - * Disable preemption until the scheduler is running. > > - * Reset by start_kernel()->sched_init()->init_idle(). > > + * Disable preemption until the scheduler is running -- use an unconditional > > + * value so that it also works on !PREEMPT_COUNT kernels. > > * > > - * We include PREEMPT_ACTIVE to avoid cond_resched() from working > > - * before the scheduler is active -- see should_resched(). > > + * Reset by start_kernel()->sched_init()->init_idle(). > > Reset by start_kernel()->sched_init()->init_idle()->init_idle_preempt_count(). > > Other than that. > > Reviewed-by: Steven Rostedt Reviewed-by: Thomas Gleixner