From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933509AbbJAMQh (ORCPT ); Thu, 1 Oct 2015 08:16:37 -0400 Received: from www.linutronix.de ([62.245.132.108]:33471 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932255AbbJAMQf (ORCPT ); Thu, 1 Oct 2015 08:16:35 -0400 Date: Thu, 1 Oct 2015 14:15:54 +0200 (CEST) From: Thomas Gleixner To: Andi Kleen cc: x86@kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] x86: Fix thermal throttling reporting after kexec In-Reply-To: <1443125443-24691-1-git-send-email-andi@firstfloor.org> Message-ID: References: <1443125443-24691-1-git-send-email-andi@firstfloor.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 24 Sep 2015, Andi Kleen wrote: > The per CPU thermal vector init code checks if the thermal > vector is already installed and complains and bails out if > it is. > > This happens after kexec, as kernel shut down does > not clear the thermal vector APIC register. So the obvious question is, why don't we do that. > Just remove the check. I checked the code and there's > no valid code paths where the thermal init code for a CPU > could be called multiple times. I'm not against removing that check as it does not really add value, but we still should clear the APIC register at shut down, right? Thanks, tglx