From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755120AbbJIOCW (ORCPT ); Fri, 9 Oct 2015 10:02:22 -0400 Received: from www.linutronix.de ([62.245.132.108]:37722 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754970AbbJIOCV (ORCPT ); Fri, 9 Oct 2015 10:02:21 -0400 Date: Fri, 9 Oct 2015 16:01:43 +0200 (CEST) From: Thomas Gleixner To: Andy Shevchenko cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H . Peter Anvin" , x86@kernel.org Subject: Re: [PATCH 1/1] x86/intel-mid: modify a code to suppress a warning In-Reply-To: <1444397355-82695-1-git-send-email-andriy.shevchenko@linux.intel.com> Message-ID: References: <1444397355-82695-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Oct 2015, Andy Shevchenko wrote: Please stop to write subject lines like this. x86/intel-mid: modify a code to suppress a warning This is completely useless as it does not tell what kind of warning (compile time, runtime). Further it says that the patch modifies code, which is completely pointless, right? What's wrong with: x86/intel-mid: Make intel_mid_ops static I end up rewriting your subject lines and changelogs on a regular base. You really should have noticed that by now and started to spend a little bit more effort yourself. Thanks, tglx