From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756815AbbJIRx3 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 9 Oct 2015 13:53:29 -0400
Received: from www.linutronix.de ([62.245.132.108]:38745 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756657AbbJIRx2 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 9 Oct 2015 13:53:28 -0400
Date: Fri, 9 Oct 2015 19:52:49 +0200 (CEST)
From: Thomas Gleixner <tglx@linutronix.de>
To: Duc Dang <dhdang@apm.com>
cc: Marc Zyngier <marc.zyngier@arm.com>, Jason Cooper <jason@lakedaemon.net>,
        linux-arm <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        patches <patches@apm.com>
Subject: Re: arm/arm64: GICv2 driver does not have irq_disable implemented
In-Reply-To: <CADaLND=spbEHLZXmqsVRDsPAyNKXJHnc=Yy6ujY0em74dB5CbA@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1510091951250.6097@nanos>
References: <CADaLND=spbEHLZXmqsVRDsPAyNKXJHnc=Yy6ujY0em74dB5CbA@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 9 Oct 2015, Duc Dang wrote:
> Hi Thomas, Marc, Jason and All,
> 
> In APM ARM64 X-Gene Enet controller driver, we use disable_irq_nosync to
> disable interrupt before calling __napi_schedule to schedule packet handler
> to process the Tx/Rx packets.

Which is wrong to begin with. Disable the interrupt at the device
level not at the interrupt line level.
 
Thanks,

	tglx