From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751703AbbJKJtn (ORCPT ); Sun, 11 Oct 2015 05:49:43 -0400 Received: from www.linutronix.de ([62.245.132.108]:41423 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491AbbJKJtm (ORCPT ); Sun, 11 Oct 2015 05:49:42 -0400 Date: Sun, 11 Oct 2015 11:49:01 +0200 (CEST) From: Thomas Gleixner To: Bjorn Helgaas cc: Romain Bezut , linux-pci@vger.kernel.org, bhelgaas@google.com, linux-kernel@vger.kernel.org, Neil Horman Subject: Re: [PATCH] PCI/MSI: Export all remapped MSIs to sysfs attributes In-Reply-To: <20151009223315.GC16112@localhost> Message-ID: References: <1443051076-27716-1-git-send-email-rbezut@gmail.com> <20151009223315.GC16112@localhost> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 9 Oct 2015, Bjorn Helgaas wrote: > On Thu, Sep 24, 2015 at 01:31:16AM +0200, Romain Bezut wrote: > > irqbalance uses these attributes to populate its internal database, which is > > then used to bind the irq on the appropriate NUMA node. > > > > On a device accepting multiple MSIs and with interrupt remapping enabled, > > only the first irq entry is exported to msi_irqs directory. > > This results in irqbalance having no clue of the NUMA affinity for the extra > > irqs and starting to bind them on random nodes. > > > > This patch exports all MSI interrupts as sysfs attributes when relevant. > > > > Signed-off-by: Romain Bezut > > This seems like it makes sense to me. Do you have any bug reports > related to this problem? If so, I'll mention them in the changelog. > > Added Neil, Thomas, and linux-kernel since this is of interest to folks > beyond the usual linux-pci audience. Acked-by: Thomas Gleixner