From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752042AbbJKRfc (ORCPT ); Sun, 11 Oct 2015 13:35:32 -0400 Received: from www.linutronix.de ([62.245.132.108]:41917 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751073AbbJKRfb (ORCPT ); Sun, 11 Oct 2015 13:35:31 -0400 Date: Sun, 11 Oct 2015 19:34:45 +0200 (CEST) From: Thomas Gleixner To: Figo cc: mingo@redhat.com, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce. In-Reply-To: <1444473404-24058-1-git-send-email-tianfei.zhang@intel.com> Message-ID: References: <1444473404-24058-1-git-send-email-tianfei.zhang@intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Figo, On Sat, 10 Oct 2015, Figo wrote: Thanks for resending, but let me clarify a few things. Subject line: [PATCH 1/1] I have a board it block on i8259A_shutdown when I want to poweroff. It is not always re-produce. That's not a proper patch subject line. It should start with the subsystem and the particular unit in the subsystem you are modifying. [PATCH] x86/i8259: The subject itself should contain a short and understandable description of the modification. Something like this: [PATCH] x86/i8259: Take i8259_lock in i8259A_shutdown() or [PATCH] x86/i8259: Prevent race in i8259A_shutdown() Ok? That must be followed by an explanation of the problem and how the modification of the code solves it. Ok? Aside of that I provided you another example of a problem which is not cured by your patch, but I can't find an answer to that either. I explicitely asked you for more information. Please always address the questions a reviewer asks you. If the questions are not clear to you, feel free to ask for clarification. Thanks, tglx