From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751926AbbJKUVb (ORCPT ); Sun, 11 Oct 2015 16:21:31 -0400 Received: from www.linutronix.de ([62.245.132.108]:42113 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751278AbbJKUVa (ORCPT ); Sun, 11 Oct 2015 16:21:30 -0400 Date: Sun, 11 Oct 2015 22:20:49 +0200 (CEST) From: Thomas Gleixner To: Andy Shevchenko cc: Ingo Molnar , "H. Peter Anvin" , LKML , x86@kernel.org, Steven Rostedt , Peter Zijlstra Subject: Re: [PATCH, resend 1/1] x86/kernel: re-use %*ph specifier In-Reply-To: <1443791813-142403-1-git-send-email-andriy.shevchenko@linux.intel.com> Message-ID: References: <1443791813-142403-1-git-send-email-andriy.shevchenko@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2 Oct 2015, Andy Shevchenko wrote: > %*ph specifier allows to dump data in hex format using the poiter to a buffer. > This is suitable to use here. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/jump_label.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/jump_label.c b/arch/x86/kernel/jump_label.c > index e565e0e..8da5254 100644 > --- a/arch/x86/kernel/jump_label.c > +++ b/arch/x86/kernel/jump_label.c > @@ -31,8 +31,8 @@ static void bug_at(unsigned char *ip, int line) > * Something went wrong. Crash the box, as something could be > * corrupting the kernel. > */ > - pr_warning("Unexpected op at %pS [%p] (%02x %02x %02x %02x %02x) %s:%d\n", > - ip, ip, ip[0], ip[1], ip[2], ip[3], ip[4], __FILE__, line); > + pr_warn("Unexpected op at %pS [%p] (%5ph) %s:%d\n", > + ip, ip, ip, __FILE__, line); We really do not need the file printed here. We better have the message starting with "jumplabel: Unexpected ...." And it should not be a warning as we BUG() right after that. pr_crit() is probably the right choice, though I wonder whether we should panic() right away when that happens. > BUG(); Thanks, tglx