From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbbJLJdf (ORCPT ); Mon, 12 Oct 2015 05:33:35 -0400 Received: from www.linutronix.de ([62.245.132.108]:43601 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbbJLJdd (ORCPT ); Mon, 12 Oct 2015 05:33:33 -0400 Date: Mon, 12 Oct 2015 11:32:56 +0200 (CEST) From: Thomas Gleixner To: Oleksij Rempel cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com, jason@lakedaemon.net Subject: Re: [PATCH v6 1/2] ARM: irqchip: mxs: prepare driver for HW with different offsets In-Reply-To: <561B7D60.4040808@rempel-privat.de> Message-ID: References: <1444482507-6748-1-git-send-email-linux@rempel-privat.de> <1444482507-6748-2-git-send-email-linux@rempel-privat.de> <561B7D60.4040808@rempel-privat.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 12 Oct 2015, Oleksij Rempel wrote: > Am 11.10.2015 um 19:58 schrieb Thomas Gleixner: > >> + icoll_add_domain(np, ICOLL_NUM_IRQS); > >> > >> - icoll_domain = irq_domain_add_linear(np, ICOLL_NUM_IRQS, > >> - &icoll_irq_domain_ops, NULL); > >> return icoll_domain ? 0 : -ENODEV; > > > > In case of !icoll_domain this return is not reached as you paniced > > already. So why would we still check icoll_domain? > > I'm paniced on !icoll_base, icoll_domain will give only warning. > http://lxr.free-electrons.com/source/kernel/irq/irqdomain.c#L52 > > Or do i miss some thing? Yes. Your patch makes that: >> + if (!icoll_domain) >> + panic("%s: unable add irq domain", np->full_name); Thanks, tglx