mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Chris Metcalf <cmetcalf@ezchip.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Mike Galbraith <umgwanakikbuti@gmail.com>,
	Dave Jones <davej@redhat.com>, Oleg Nesterov <oleg@redhat.com>,
	Christoph Lameter <cl@linux.com>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	"Paul E . McKenney" <paulmck@linux.vnet.ibm.com>,
	Rik van Riel <riel@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] nohz: Revert "nohz: Set isolcpus when nohz_full is set"
Date: Mon, 12 Oct 2015 21:52:08 +0200 (CEST)	[thread overview]
Message-ID: <alpine.DEB.2.11.1510122151460.6097@nanos> (raw)
In-Reply-To: <1444663283-30068-1-git-send-email-fweisbec@gmail.com>

On Mon, 12 Oct 2015, Frederic Weisbecker wrote:
> This reverts commit 8cb9764fc88b41db11f251e8b2a0d006578b7eb4.
> 
> We assumed that nohz full users always want scheduler isolation on full
> dynticks CPUs, therefore we included nohz full CPUs on cpu_isolated_map.
> This means that tasks run by default on CPUs outside the nohz_full range
> unless their affinity is explicity overwritten.
> 
> This suits pure isolation workloads but when the machine is needed to
> run common workloads, the available sets of CPUs to run common tasks
> becomes reduced.
> 
> We reach an extreme case when CONFIG_NO_HZ_FULL_ALL is enabled as it
> leaves only CPU 0 for non-isolation tasks, which makes people think that
> their supercomputer regressed to 90's UP.
> 
> Some nohz full users appear to be interested in running normal workloads
> either before or after an isolation workload. Nohz full isn't optimized
> toward normal workloads but it's still better than UP performance.
> 
> We are reaching a limitation in kernel presets here. Lets revert this
> cpu_isolated_map inclusion and let userspace do its own scheduler
> isolation using cpusets or explicit affinity settings.

Acked-by: Thomas Gleixner <tglx@linutronix.de>

  parent reply	other threads:[~2015-10-12 19:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-12 15:21 Frederic Weisbecker
2015-10-12 15:32 ` Paul E. McKenney
2015-10-12 16:20   ` Frederic Weisbecker
2015-10-12 16:53     ` Paul E. McKenney
2015-10-12 16:55       ` Chris Metcalf
2015-10-12 17:42         ` Frederic Weisbecker
2015-10-12 17:45           ` Christoph Lameter
2015-10-12 17:50             ` Frederic Weisbecker
2015-10-12 17:52             ` Paul E. McKenney
2015-10-12 17:55               ` Frederic Weisbecker
2015-10-12 18:22                 ` Paul E. McKenney
2015-10-12 18:27                   ` Christoph Lameter
2015-10-12 18:03           ` Chris Metcalf
2015-10-12 19:52 ` Thomas Gleixner [this message]
2015-10-20  9:31 ` [tip:sched/core] " tip-bot for Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1510122151460.6097@nanos \
    --to=tglx@linutronix.de \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux.com \
    --cc=cmetcalf@ezchip.com \
    --cc=davej@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    --cc=umgwanakikbuti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®