From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753088AbbJMNiK (ORCPT ); Tue, 13 Oct 2015 09:38:10 -0400 Received: from www.linutronix.de ([62.245.132.108]:50031 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbJMNiI (ORCPT ); Tue, 13 Oct 2015 09:38:08 -0400 Date: Tue, 13 Oct 2015 15:37:30 +0200 (CEST) From: Thomas Gleixner To: Qais Yousef cc: linux-kernel@vger.kernel.org, jason@lakedaemon.net, marc.zyngier@arm.com, jiang.liu@linux.intel.com, ralf@linux-mips.org, linux-mips@linux-mips.org Subject: Re: [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code to irq core In-Reply-To: <1444731382-19313-8-git-send-email-qais.yousef@imgtec.com> Message-ID: References: <1444731382-19313-1-git-send-email-qais.yousef@imgtec.com> <1444731382-19313-8-git-send-email-qais.yousef@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Oct 2015, Qais Yousef wrote: > +/** > + * irq_reserve_ipi() - setup an IPI to destination cpumask > + * @domain: IPI domain > + * @dest: cpumask of cpus to receive the IPI > + * > + * Allocate a virq that can be used to send IPI to any CPU in dest mask. > + * > + * On success it'll return linux irq number and 0 on failure > + */ > +unsigned int irq_reserve_ipi(struct irq_domain *domain, > + const struct ipi_mask *dest) > +{ > + struct irq_data *data; > + int virq; > + unsigned int nr_irqs; Please order them so: + struct irq_data *data; + unsigned int nr_irqs; + int virq; Much simpler to read. > + if (domain == NULL) > + domain = irq_default_domain; /* need a separate ipi_default_domain? */ No tail comments please. We should neither use irq_default_domain nor have an ipi_default_domain. > + > + if (domain == NULL) { > + pr_warn("Must provide a valid IPI domain!\n"); > + return 0; > + } > + > + if (!irq_domain_is_ipi(domain)) { > + pr_warn("Not an IPI domain!\n"); > + return 0; > + } > + > + /* always allocate a virq per cpu */ > + nr_irqs = bitmap_weight(dest->cpumask, dest->nbits);; Double semicolon > + > + virq = irq_domain_alloc_descs(-1, nr_irqs, 0, NUMA_NO_NODE); > + if (virq <= 0) { > + pr_warn("Can't reserve IPI, failed to alloc descs\n"); > + return 0; > + } > + > + /* we are reusing hierarchy alloc function, should we create another one? */ > + virq = __irq_domain_alloc_irqs(domain, virq, nr_irqs, NUMA_NO_NODE, > + (void *) dest, true); > + if (virq <= 0) { > + pr_warn("Can't reserve IPI, failed to alloc irqs\n"); > + goto free_descs; > + } > + > + data = irq_get_irq_data(virq); > + bitmap_copy(data->ipi_mask.cpumask, dest->cpumask, dest->nbits); > + data->ipi_mask.nbits = dest->nbits; This does only initialize the first virq data. What about the others? > + return virq; > + > +free_descs: > + irq_free_descs(virq, nr_irqs); > + return 0; > +} > + > +/** > + * irq_destroy_ipi() - unreserve an IPI that was previously allocated > + * @irq: linux irq number to be destroyed > + * > + * Return an IPI allocated with irq_reserve_ipi() to the system. That wants to explain that it actually destroys a number of virqs not just the primary one. Thanks, tglx