From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932172AbbJNUpv (ORCPT ); Wed, 14 Oct 2015 16:45:51 -0400 Received: from www.linutronix.de ([62.245.132.108]:57167 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752964AbbJNUpt (ORCPT ); Wed, 14 Oct 2015 16:45:49 -0400 Date: Wed, 14 Oct 2015 22:44:39 +0200 (CEST) From: Thomas Gleixner To: LABBE Corentin cc: ameenali023@gmail.com, bp@alien8.de, dan.carpenter@oracle.com, davem@davemloft.net, firogm@gmail.com, herbert@gondor.apana.org.au, hpa@zytor.com, mingo@redhat.com, minipli@googlemail.com, smueller@chronox.de, tim.c.chen@linux.intel.com, x86@kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: x86: Remove duplicate define of SHA1_DIGEST_SIZE In-Reply-To: <1444850171-17931-1-git-send-email-clabbe.montjoie@gmail.com> Message-ID: References: <1444850171-17931-1-git-send-email-clabbe.montjoie@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 14 Oct 2015, LABBE Corentin wrote: > The sha x86 crypto code use two define for the same thing: > NUM_SHA1_DIGEST_WORDS and SHA1_DIGEST_LENGTH > Replace them by SHA1_DIGEST_SIZE/4 That's wrong. Use only one for the number of words and make the define so it's derived from the LENGTH. Thanks, tglx