From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752332AbbJOKTi (ORCPT ); Thu, 15 Oct 2015 06:19:38 -0400 Received: from www.linutronix.de ([62.245.132.108]:59505 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbbJOKTg (ORCPT ); Thu, 15 Oct 2015 06:19:36 -0400 Date: Thu, 15 Oct 2015 12:18:49 +0200 (CEST) From: Thomas Gleixner To: Qais Yousef cc: Marc Zyngier , Markos Chandras , linux-mips@linux-mips.org, Alex Smith , Jason Cooper , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] irqchip: irq-mips-gic: Provide function to map GIC user section In-Reply-To: <561F73D6.8040300@imgtec.com> Message-ID: References: <1443435117-17144-1-git-send-email-markos.chandras@imgtec.com> <1444642843-16375-1-git-send-email-markos.chandras@imgtec.com> <561B82BA.30809@arm.com> <561F73D6.8040300@imgtec.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 15 Oct 2015, Qais Yousef wrote: > It could be refactored but the DT binding already specifies the GIC timer as a > subnode of GIC. Exposing this usermode register is the only thing left in the > register set that GIC driver wasn't dealing with. > > Little gain in changing all of this now I think? Well, the not so little gain is clear separation and a sane design. Thanks, tglx