From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753872AbbJPJyH (ORCPT ); Fri, 16 Oct 2015 05:54:07 -0400 Received: from www.linutronix.de ([62.245.132.108]:36596 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbbJPJyF (ORCPT ); Fri, 16 Oct 2015 05:54:05 -0400 Date: Fri, 16 Oct 2015 11:53:21 +0200 (CEST) From: Thomas Gleixner To: Marc Zyngier cc: Jiang Liu , Bjorn Helgaas , linux-kernel@vger.kernel.org Subject: Re: [PATCH] genirq/msi: Do not use pci_msi_[un]mask_irq as default methods In-Reply-To: Message-ID: References: <1444760085-27857-1-git-send-email-marc.zyngier@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Bjorn, On Thu, 15 Oct 2015, Thomas Gleixner wrote: > On Tue, 13 Oct 2015, Marc Zyngier wrote: > > > When we create a generic MSI domain, that MSI_FLAG_USE_DEF_CHIP_OPS > > is set, and that any of .mask or .unmask are NULL in the irq_chip > > structure, we set them to pci_msi_[un]mask_irq. > > > > This is a bad idea for at least two reasons: > > - PCI_MSI might not be selected, kernel fails to build (yes, this is > > legitimate, at least on arm64!) > > - This may not be a PCI/MSI domain at all (platform MSI, for example) > > > > Either way, this looks wrong. Move the overriding of mask/unmask to > > the PCI counterpart, and panic is any of these two methods is not > > set in the core code (they really should be present). > > > > Signed-off-by: Marc Zyngier Should I take that one? Thanks, tglx