From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753521AbbJSKOO (ORCPT ); Mon, 19 Oct 2015 06:14:14 -0400 Received: from www.linutronix.de ([62.245.132.108]:45073 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750876AbbJSKOM (ORCPT ); Mon, 19 Oct 2015 06:14:12 -0400 Date: Mon, 19 Oct 2015 12:13:26 +0200 (CEST) From: Thomas Gleixner To: Sekhar Nori cc: Tony Lindgren , Jason Cooper , Marc Zyngier , John Ogness , Felipe Balbi , Linux OMAP Mailing List , linux-kernel@vger.kernel.org Subject: Re: [PATCH] irqchip: omap-intc: fix spurious irq handling In-Reply-To: <3d433cfeeb93366cadbb1668ebeac2e8006b0fd5.1445247844.git.nsekhar@ti.com> Message-ID: References: <3d433cfeeb93366cadbb1668ebeac2e8006b0fd5.1445247844.git.nsekhar@ti.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Oct 2015, Sekhar Nori wrote: > + /* > + * A spurious IRQ can result if interrupt that triggered the > + * sorting is no longer active during the sorting (10 INTC > + * functional clock cycles after interrupt assertion). Or a > + * change in interrupt mask affected the result during sorting > + * time. There is no special handling required except ignoring > + * the SIR register value just read and retrying. > + * See section 6.2.5 of AM335x TRM Literature Number: SPRUH73K > + */ > + if ((irqnr & SPURIOUSIRQ_MASK) == SPURIOUSIRQ_MASK) { > + pr_debug_ratelimited("%s: spurious irq!\n", __func__); I'd prefer that this is a pr_once() and the spurious interrupt counter is incremented. That's far more useful as it gives you real information about the frequency of the issue. Thanks, tglx