From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932480AbbKCUBx (ORCPT ); Tue, 3 Nov 2015 15:01:53 -0500 Received: from www.linutronix.de ([62.245.132.108]:46565 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236AbbKCUBv (ORCPT ); Tue, 3 Nov 2015 15:01:51 -0500 Date: Tue, 3 Nov 2015 21:01:08 +0100 (CET) From: Thomas Gleixner To: Grygorii Strashko cc: Sebastian Andrzej Siewior , linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sekhar Nori Subject: Re: [v4.1.10-rt10][PATCH 0/2] PCI: dra7xx/dwc: fix "WARNING: CPU: 1 PID: 82 at kernel/irq/handle.c:150 handle_irq_event_percpu" In-Reply-To: <563906CE.6090707@ti.com> Message-ID: References: <1446492626-24396-1-git-send-email-grygorii.strashko@ti.com> <5638BAAE.6050909@linutronix.de> <563906CE.6090707@ti.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 3 Nov 2015, Grygorii Strashko wrote: > On 11/03/2015 03:46 PM, Sebastian Andrzej Siewior wrote: > > On 11/02/2015 08:30 PM, Grygorii Strashko wrote: > >> On -RT above code will generate warnings, because driver_xx_hw_irq_handler() > >> will be forced threaded (by default) and, as result, generic_handle_irq() > >> will be called with IRQs enabled. To W/A this issue generic_handle_irq() can > >> be surrounded by raw_spin_lock_irqsave/irqrestore(wa_lock). > > > > and what happens without -RT if you boot threadedirqs? > > > > Yep. It will still warn :( Can be reworked to cover this case also, i think > (if overall concept will be accepted) wa_lock - I read that "Warning Annihilation Lock" - does not really qualify as a concept. Thanks, tglx