From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348AbbK0Jav (ORCPT ); Fri, 27 Nov 2015 04:30:51 -0500 Received: from www.linutronix.de ([62.245.132.108]:42314 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754040AbbK0Jas (ORCPT ); Fri, 27 Nov 2015 04:30:48 -0500 Date: Fri, 27 Nov 2015 10:30:03 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 15/37] x86, pkeys: pass VMA down in to fault signal generation code In-Reply-To: <20151117033532.BDBC53AC@viggo.jf.intel.com> Message-ID: References: <20151117033511.BFFA1440@viggo.jf.intel.com> <20151117033532.BDBC53AC@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2015, Dave Hansen wrote: > During a page fault, we look up the VMA to ensure that the fault > is in a region with a valid mapping. But, in the top-level page > fault code we don't need the VMA for much else. Once we have > decided that an access is bad, we are going to send a signal no > matter what and do not need the VMA any more. So we do not pass > it down in to the signal generation code. > > But, for protection keys, we need the VMA. It tells us *which* > protection key we violated if we get a PF_PK. So, we need to > pass the VMA down and fill in siginfo->si_pkey. > > Signed-off-by: Dave Hansen Reviewed-by: Thomas Gleixner