From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754490AbbK0Jus (ORCPT ); Fri, 27 Nov 2015 04:50:48 -0500 Received: from www.linutronix.de ([62.245.132.108]:42416 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754256AbbK0Jup (ORCPT ); Fri, 27 Nov 2015 04:50:45 -0500 Date: Fri, 27 Nov 2015 10:49:59 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 16/37] x86, pkeys: notify userspace about protection key faults In-Reply-To: <20151117033533.21D3A57C@viggo.jf.intel.com> Message-ID: References: <20151117033511.BFFA1440@viggo.jf.intel.com> <20151117033533.21D3A57C@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2015, Dave Hansen wrote: > Note that _pkey is a 64-bit value. The current hardware only > supports 4-bit protection keys. We do this because there is > _plenty_ of space in _sigfault and it is possible that future > processors would support more than 4 bits of protection keys. > > Signed-off-by: Dave Hansen > --- > > b/arch/x86/include/asm/pgtable_types.h | 5 ++ > b/arch/x86/mm/fault.c | 59 ++++++++++++++++++++++++++++++++- > b/include/uapi/asm-generic/siginfo.h | 17 ++++++--- > b/kernel/signal.c | 4 ++ I'd be nice to split the core changes from the x86 implementation. Other than that: Reviewed-by: Thomas Gleixner