From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754398AbbK0JyS (ORCPT ); Fri, 27 Nov 2015 04:54:18 -0500 Received: from www.linutronix.de ([62.245.132.108]:42437 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750759AbbK0JyR (ORCPT ); Fri, 27 Nov 2015 04:54:17 -0500 Date: Fri, 27 Nov 2015 10:53:32 +0100 (CET) From: Thomas Gleixner To: Dave Hansen cc: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com Subject: Re: [PATCH 18/37] mm: factor out VMA fault permission checking In-Reply-To: <20151117033536.8A3668CE@viggo.jf.intel.com> Message-ID: References: <20151117033511.BFFA1440@viggo.jf.intel.com> <20151117033536.8A3668CE@viggo.jf.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 16 Nov 2015, Dave Hansen wrote: > +bool vma_permits_fault(struct vm_area_struct *vma, unsigned int fault_flags) > +{ > + vm_flags_t vm_flags = > + (fault_flags & FAULT_FLAG_WRITE) ? VM_WRITE : VM_READ; > + vm_flags_t vm_flags; vm_flags = (fault_flags & FAULT_FLAG_WRITE) ? VM_WRITE : VM_READ; makes it readable w/o brain twisting. Thanks, tglx