From: Thomas Gleixner <tglx@linutronix.de>
To: Li Bin <huawei.libin@huawei.com>
Cc: rostedt@goodmis.org, mingo@redhat.com,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Subject: Re: [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct
Date: Sat, 5 Dec 2015 18:12:57 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1512051811320.3595@nanos> (raw)
In-Reply-To: <1449214067-12177-6-git-send-email-huawei.libin@huawei.com>
On Fri, 4 Dec 2015, Li Bin wrote:
> --- a/arch/x86/kernel/ftrace.c
> +++ b/arch/x86/kernel/ftrace.c
> @@ -106,13 +106,12 @@ ftrace_modify_code_direct(unsigned long ip, unsigned const char *old_code,
> unsigned char replaced[MCOUNT_INSN_SIZE];
>
> /*
> - * Note: Due to modules and __init, code can
> - * disappear and change, we need to protect against faulting
> - * as well as code changing. We do this by using the
> - * probe_kernel_* functions.
> - *
> - * No real locking needed, this code is run through
> - * kstop_machine, or before SMP starts.
> + * Note:
> + * We are paranoid about modifying text, as if a bug were to happen, it
> + * could cause us to read or write to someplace that could cause harm.
> + * Carefully read and modify the code with aarch64_insn_*() which uses
aarch64_insn_() is related to x86 in which way?
Thanks,
tglx
next prev parent reply other threads:[~2015-12-05 17:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-04 7:27 [PATCH 0/5] ftrace: fix ftrace misleading comments for arch using it Li Bin
2015-12-04 7:27 ` [PATCH 1/5] ia64: ftrace: fix the comments for ftrace_modify_code Li Bin
2015-12-04 17:36 ` Luck, Tony
2015-12-04 7:27 ` [PATCH 2/5] metag: " Li Bin
2015-12-04 7:27 ` [PATCH 3/5] powerpc: " Li Bin
2015-12-04 7:27 ` [PATCH 4/5] sh: " Li Bin
2015-12-04 12:44 ` Sergei Shtylyov
2015-12-04 7:27 ` [PATCH 5/5] x86: ftrace: fix the comments for ftrace_modify_code_direct Li Bin
2015-12-05 17:12 ` Thomas Gleixner [this message]
2015-12-05 22:52 ` Steven Rostedt
2015-12-06 1:59 ` Li Bin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1512051811320.3595@nanos \
--to=tglx@linutronix.de \
--cc=hpa@zytor.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®