From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932833AbbLGUR0 (ORCPT ); Mon, 7 Dec 2015 15:17:26 -0500 Received: from www.linutronix.de ([62.245.132.108]:41512 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932593AbbLGURZ (ORCPT ); Mon, 7 Dec 2015 15:17:25 -0500 Date: Mon, 7 Dec 2015 21:16:37 +0100 (CET) From: Thomas Gleixner To: John Stultz cc: lkml , Sasha Levin , Richard Cochran Subject: Re: [RFC][PATCH -reworked] time: Verify time values in adjtimex ADJ_SETOFFSET to avoid overflow In-Reply-To: Message-ID: References: <1449519118-4950-1-git-send-email-john.stultz@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 7 Dec 2015, John Stultz wrote: > On Mon, Dec 7, 2015 at 12:11 PM, John Stultz wrote: > > diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c > > index 99188ee..a37222b 100644 > > --- a/kernel/time/timekeeping.c > > +++ b/kernel/time/timekeeping.c > > @@ -1986,6 +1986,7 @@ int do_adjtimex(struct timex *txc) > > > > if (txc->modes & ADJ_SETOFFSET) { > > struct timespec delta; > > + > > delta.tv_sec = txc->time.tv_sec; > > delta.tv_nsec = txc->time.tv_usec; > > if (!(txc->modes & ADJ_NANO)) > > Gah. Except for this needless whitespace. Ignore that please. It's needless for this patch, but correct by itself :)