mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jeff Merkey <linux.mdb@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, hpa@zytor.com,
	x86@kernel.org, peterz@infradead.org, luto@kernel.org
Subject: Re: [PATCH V3] Fix INT1 Recursion with unregistered breakpoints
Date: Sat, 19 Dec 2015 16:05:00 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1512191603300.28591@nanos> (raw)
In-Reply-To: <20151215061250.GA7233@localhost.localdomain>

On Mon, 14 Dec 2015, Jeff Merkey wrote:
> +		/*
> +		* check if we got an execute breakpoint
> +		* from the dr7 register.  if we did, set
> +		* the resume flag to avoid int1 recursion.

Malformatted comment as any other comment you touched.

> +		*/
> +		if ((dr7 & (3 << ((i * 4) + 16))) == 0)
> +			args->regs->flags |= X86_EFLAGS_RF;

This still uses magic numbers instead of the proper defines. I asked
for that before.

Thanks,

	tglx

  parent reply	other threads:[~2015-12-19 15:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-15  6:12 Jeff Merkey
2015-12-15 18:37 ` Jeff Merkey
2015-12-15 19:12 ` Jeff Merkey
2015-12-19 15:05 ` Thomas Gleixner [this message]
2015-12-19 22:22   ` Jeff Merkey
2015-12-19 23:12   ` Jeff Merkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1512191603300.28591@nanos \
    --to=tglx@linutronix.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.mdb@gmail.com \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®