From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752307AbcAFRf5 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jan 2016 12:35:57 -0500
Received: from www.linutronix.de ([62.245.132.108]:37690 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751595AbcAFRfv (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jan 2016 12:35:51 -0500
Date: Wed, 6 Jan 2016 18:34:57 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
cc: Prarit Bhargava <prarit@redhat.com>, lkml <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, Xunlei Pang <pang.xunlei@linaro.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Baolin Wang <baolin.wang@linaro.org>, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH 1/2] kernel, timekeeping, add trylock option to
 ktime_get_with_offset()
In-Reply-To: <CALAqxLUsQNswOM33vMezyEpM7L8tmK-oOkDwQ2UxNdtEXsHX-w@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1601061830460.3574@nanos>
References: <1452085234-10667-1-git-send-email-prarit@redhat.com> <1452085234-10667-2-git-send-email-prarit@redhat.com> <CALAqxLUsQNswOM33vMezyEpM7L8tmK-oOkDwQ2UxNdtEXsHX-w@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 6 Jan 2016, John Stultz wrote:
> On Wed, Jan 6, 2016 at 5:00 AM, Prarit Bhargava <prarit@redhat.com> wrote:
> > -ktime_t ktime_get_with_offset(enum tk_offsets offs)
> > +ktime_t ktime_get_with_offset(enum tk_offsets offs, int trylock)
> >  {
> >         struct timekeeper *tk = &tk_core.timekeeper;
> >         unsigned int seq;
> >         ktime_t base, *offset = offsets[offs];
> >         s64 nsecs;
> > +       unsigned long flags = 0;
> > +
> > +       if (unlikely(!timekeeping_initialized))
> > +               return ktime_set(0, 0);
> >
> >         WARN_ON(timekeeping_suspended);
> >
> > +       if (trylock && !raw_spin_trylock_irqsave(&timekeeper_lock, flags))
> > +               return ktime_set(KTIME_MAX, 0);
> 
> Wait.. this doesn't make sense. The timekeeper lock is only for reading.
> 
> What I was suggesting to you off line is to have something that avoids
> spinning on the seqcounter should if a bug occurs and we IPI all the
> cpus, that we don't deadlock or block any printk messages.

We could also extend the fast timekeeper with boot/real/tai extensions and use
that for printk. You can use ktime_get_mono_fast_ns() today.

Thanks,

	tglx