From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756929AbcAJKOb (ORCPT ); Sun, 10 Jan 2016 05:14:31 -0500 Received: from www.linutronix.de ([62.245.132.108]:42514 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754591AbcAJKOa (ORCPT ); Sun, 10 Jan 2016 05:14:30 -0500 Date: Sun, 10 Jan 2016 11:13:35 +0100 (CET) From: Thomas Gleixner To: Yoshinori Sato cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] irq: action setting before irq_startup In-Reply-To: <1452340701-20697-1-git-send-email-ysato@users.sourceforge.jp> Message-ID: References: <1452340701-20697-1-git-send-email-ysato@users.sourceforge.jp> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 9 Jan 2016, Yoshinori Sato wrote: > In non shared and non threaded IRQ case. > irq_startup calling before desc->action initialize. And how does that matter? > Signed-off-by: Yoshinori Sato > --- > kernel/irq/manage.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c > index 0eebaee..f6cdb63 100644 > --- a/kernel/irq/manage.c > +++ b/kernel/irq/manage.c > @@ -1272,6 +1272,8 @@ __setup_irq(unsigned int irq, struct irq_desc *desc, struct irqaction *new) > goto out_mask; > } > > + *old_ptr = new; > + > if (!shared) { > ret = irq_request_resources(desc); > if (ret) { So in case irq_request_resources() fails, you leak the action in the irq descriptor. Again, what's the problem you are trying to solve? Thanks, tglx