From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934846AbcATRnZ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 Jan 2016 12:43:25 -0500
Received: from www.linutronix.de ([62.245.132.108]:32863 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934158AbcATRnY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 Jan 2016 12:43:24 -0500
Date: Wed, 20 Jan 2016 18:42:23 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: John Stultz <john.stultz@linaro.org>
cc: Jeff Merkey <linux.mdb@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [BUG REPORT] ktime_get_ts64 causes Hard Lockup
In-Reply-To: <CALAqxLXMUcucGd7xQ8JD120LdiOr9qbb-RybwJYx95c=V+9p7w@mail.gmail.com>
Message-ID: <alpine.DEB.2.11.1601201837300.3575@nanos>
References: <CAO6TR8UORNMgEYCxW9s-UcRjiOzs2CUpyZ+Wd=KoDv045ByiCg@mail.gmail.com> <CAO6TR8XHdnvfW1Y2yWBTnGz4d2fjgXvj_9yHmfxSork2bBNNew@mail.gmail.com> <CAO6TR8V45TwC2YZF863o+Gaf5BboDaQg3+naV=qUNeXiRa4LPQ@mail.gmail.com> <alpine.DEB.2.11.1601201015000.3575@nanos>
 <CAO6TR8UnGPr+mLrOwk+Zc1zEDVa7K=igX48U0-N+ZBoMo66PuA@mail.gmail.com> <CAO6TR8U51B0bGVC_nAMNuBRnwTJGVPMKz=9xO2+nSRhuOGsyFg@mail.gmail.com> <CALAqxLXMUcucGd7xQ8JD120LdiOr9qbb-RybwJYx95c=V+9p7w@mail.gmail.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 20 Jan 2016, John Stultz wrote:
> Ehrm.  A more productive route in solving this might be to cap the
> cycle delta we return from timekeeping_get_delta().
> 
> We already do this in the CONFIG_DEBUG_TIMEKEEPING, but adding a
> simple check it to the non-debug case should be doable w/o adding too
> much overhead to this very hot path.
> 
> Something like:
> if (delta > tkr->clock->max_cycles)
>     delta = tkr->clock->max_cycles;
> 
> return delta;

Well, you can make CONFIG_KDB select CONFIG_DEBUG_TIMEKEEPING.

Thanks,

	tglx