From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752569AbcAVIId (ORCPT ); Fri, 22 Jan 2016 03:08:33 -0500 Received: from www.linutronix.de ([62.245.132.108]:44562 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751378AbcAVII1 (ORCPT ); Fri, 22 Jan 2016 03:08:27 -0500 Date: Fri, 22 Jan 2016 09:07:22 +0100 (CET) From: Thomas Gleixner To: William Breathitt Gray cc: "H. Peter Anvin" , mingo@redhat.com, gregkh@linuxfoundation.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] base: isa: Remove X86_32 dependency In-Reply-To: <56A17172.4080302@gmail.com> Message-ID: References: <20160121155617.GA20054@sophia> <56A1341B.3010702@zytor.com> <56A16D28.3010205@gmail.com> <56A16DF8.5000900@zytor.com> <56A17172.4080302@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jan 2016, William Breathitt Gray wrote: > On 01/21/2016 06:47 PM, H. Peter Anvin wrote: > > Well, and as you can see from the build robot because a lot of those > > drivers simply don't compile on 64-bit systems. If nothing else you > > would have to push the 32-bit tests downward in the config dependency tree. > > Yes, you're right. There doesn't appear to be anything 32-bit specific in > the ISA bus driver itself, so these build failures must be due to configs > relying on the 32-bit dependency from CONFIG_ISA. It should be possible to > decouple the 32-bit dependency, so I'll work through the config dependency > tree and fix the build errors with explicit CONFIG_X86_32 dependencies. I'll > submit a new patch with those changes when complete. Make drivers/bus/isa.c depend on CONFIG_ISA_BUS and select that from CONFIG_ISA. That gives you the bus driver alone w/o touching any of the things which depend on x32. Thanks, tglx