From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933639AbcAYRAV (ORCPT ); Mon, 25 Jan 2016 12:00:21 -0500 Received: from www.linutronix.de ([62.245.132.108]:58623 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932253AbcAYRAS (ORCPT ); Mon, 25 Jan 2016 12:00:18 -0500 Date: Mon, 25 Jan 2016 17:59:06 +0100 (CET) From: Thomas Gleixner To: Jan Beulich cc: mingo@elte.hu, hpa@zytor.com, Juergen Gross , linux-kernel@vger.kernel.org Subject: Re: [PATCH] ix86: fix types used in pgprot cachability flags translations In-Reply-To: <56A65EB502000078000CAC72@prv-mh.provo.novell.com> Message-ID: References: <56A65EB502000078000CAC72@prv-mh.provo.novell.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 25 Jan 2016, Jan Beulich wrote: > For PAE kernels "unsigned long" is not suitable to hold page protection > flags, since _PAGE_NX doesn't fit there. This is the reason for quite a > few W+X pages getting reported as insecure during boot (observed namely > for the entire initrd range). > > Quite the other way around, "unsigned long" is inefficient for 64-bit > kernels when dealing with cachability flags alone - "unsigned int" is > sufficient here and allows for slightly smaller code to be generated. This part has nothing to do with the fix. Can you please avoid to mix fixes, which require backporting and code enhancements? Thanks, tglx