From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967047AbcAZRc6 (ORCPT ); Tue, 26 Jan 2016 12:32:58 -0500 Received: from www.linutronix.de ([62.245.132.108]:37892 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964816AbcAZRcy (ORCPT ); Tue, 26 Jan 2016 12:32:54 -0500 Date: Tue, 26 Jan 2016 18:31:49 +0100 (CET) From: Thomas Gleixner To: Zhao Qiang cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, leoyang.li@nxp.com, oss@buserror.net, xiaobo.xie@nxp.com Subject: Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere In-Reply-To: <1453338364-45129-1-git-send-email-qiang.zhao@nxp.com> Message-ID: References: <1453338364-45129-1-git-send-email-qiang.zhao@nxp.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 21 Jan 2016, Zhao Qiang wrote: > 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info How do you trigger that overflow? The above does not explain WHY we need these checks. > diff --git a/drivers/soc/fsl/qe/qe_ic.c b/drivers/soc/fsl/qe/qe_ic.c > index 5419527..90c00b7 100644 > --- a/drivers/soc/fsl/qe/qe_ic.c > +++ b/drivers/soc/fsl/qe/qe_ic.c Sigh. Another dump ground for SOC stuff? irq chip drivers belong into drivers/irqchip. Thanks, tglx