From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751580AbcAZUqg (ORCPT ); Tue, 26 Jan 2016 15:46:36 -0500 Received: from www.linutronix.de ([62.245.132.108]:38580 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbcAZUqf (ORCPT ); Tue, 26 Jan 2016 15:46:35 -0500 Date: Tue, 26 Jan 2016 21:45:32 +0100 (CET) From: Thomas Gleixner To: Brian Starkey cc: linux-kernel@vger.kernel.org, marc.zyngier@arm.com Subject: Re: [PATCH] genirq: fix trigger flags check for shared irqs In-Reply-To: <96c068ece0f5d01fc85bdbd9e0798f68180eebb8.1453204950.git.brian.starkey@arm.com> Message-ID: References: <96c068ece0f5d01fc85bdbd9e0798f68180eebb8.1453204950.git.brian.starkey@arm.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Jan 2016, Brian Starkey wrote: > For shared interrupts, if one requester passes in any IRQF_TRIGGER_* > flags whilst another doesn't, __setup_irq() can erroneously fail. > > The no-flags case should be treated as "already configured", so change > __setup_irq() to only check that the flags match if any have been > provided. What happens if that "already configured", i.e. the default setting, is conflicting with the newly requested interrupt? I rather prefer the failure than the resulting silent wreckage. Thanks, tglx