From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754318AbcA0MFI (ORCPT ); Wed, 27 Jan 2016 07:05:08 -0500 Received: from www.linutronix.de ([62.245.132.108]:42847 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752913AbcA0MFF (ORCPT ); Wed, 27 Jan 2016 07:05:05 -0500 Date: Wed, 27 Jan 2016 13:03:57 +0100 (CET) From: Thomas Gleixner To: Daniel Wagner cc: linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, Peter Zijlstra , linux-kbuild@vger.kernel.org, Marcelo Tosatti , Paolo Bonzini , "Paul E. McKenney" , Paul Gortmaker , Steven Rostedt , Boqun Feng Subject: Re: [PATCH tip v5 2/5] kbuild: Add option to turn incompatible pointer check into error In-Reply-To: <1448890711-5812-3-git-send-email-daniel.wagner@bmw-carit.de> Message-ID: References: <1448890711-5812-1-git-send-email-daniel.wagner@bmw-carit.de> <1448890711-5812-3-git-send-email-daniel.wagner@bmw-carit.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 30 Nov 2015, Daniel Wagner wrote: > > +ifdef CONFIG_ENABLE_ERR_TYPE_CHECK > +KBUILD_CFLAGS += $(call cc-option,-Werror=incompatible-pointer-types) > +endif I don't see a value for making this configurable. If the compiler supports it, we should use it. It already found a bug, so why would we make that optional? Thanks, tglx