From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934026AbcA0Rit (ORCPT ); Wed, 27 Jan 2016 12:38:49 -0500 Received: from www.linutronix.de ([62.245.132.108]:44985 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933080AbcA0Rir (ORCPT ); Wed, 27 Jan 2016 12:38:47 -0500 Date: Wed, 27 Jan 2016 18:37:42 +0100 (CET) From: Thomas Gleixner To: Mathieu Desnoyers cc: Paul Turner , Andrew Hunter , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-api , Andy Lutomirski , Andi Kleen , Dave Watson , Chris Lameter , Ingo Molnar , Ben Maurer , rostedt , "Paul E. McKenney" , Josh Triplett , Linus Torvalds , Andrew Morton , Russell King , Catalin Marinas , Will Deacon , Michael Kerrisk Subject: Re: [RFC PATCH v2 1/3] getcpu_cache system call: cache CPU number of running thread In-Reply-To: Message-ID: References: <1453913683-28915-1-git-send-email-mathieu.desnoyers@efficios.com> <1453913683-28915-2-git-send-email-mathieu.desnoyers@efficios.com> <671969438.6129.1453915918933.JavaMail.zimbra@efficios.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 27 Jan 2016, Thomas Gleixner wrote: > On Wed, 27 Jan 2016, Mathieu Desnoyers wrote: > > ----- On Jan 27, 2016, at 12:22 PM, Thomas Gleixner tglx@linutronix.de wrote: > > Sounds fair. What is the recommended typing for "ptr" then ? > > uint32_t ** or uint32_t * ? > > > > It would be expected to pass a "uint32_t *" for the set > > operation, but the "get" operation requires a "uint32_t **". > > Well, you can't change the types depending on the opcode, so you need to stick > with **. Alternatively you make it: (opcode, *newptr, **oldptr, flags);