mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jeffrey Merkey <jeffmerkey@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	dzickus@redhat.com, uobergfe@redhat.com, atomlin@redhat.com,
	mhocko@suse.cz, fweisbec@gmail.com, tj@kernel.org,
	hidehiro.kawai.ez@hitachi.com, cmetcalf@ezchip.com
Subject: Re: [PATCH 01/31] Add hard/soft lockup debugger entry points
Date: Thu, 28 Jan 2016 21:48:13 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1601282143110.3886@nanos> (raw)
In-Reply-To: <CA+ekxPXbfvjvFpOCOOENoC5+k4N0Ku7xg+oi+wb1AwER-UUbog@mail.gmail.com>

On Thu, 28 Jan 2016, Jeffrey Merkey wrote:
> On 1/28/16, Thomas Gleixner <tglx@linutronix.de> wrote:
> > I'm probably missing something obvious here.
> 
> It's a pain in the butt to grep around through assembly language in a
> function in watchdog.c that has everything declared static with no
> symbols.  It's a lot easier just to insert an INT3 in the section of
> code that has the mouse caught in the trap (inside a function that
> triggers the hard lockup) -- after all -- that's what the instruction
> is for.

AFAICT, debuggers can set breakpoints on arbitrary code lines without grepping
through assembly language. If you don't have the debug information available,
then using a debugger is pointless anyway.

This is beyond silly. If we follow your argumentation we need another
gazillion of conditional breakpoints in the kernel. Definitely not.

Thanks,

	tglx

  reply	other threads:[~2016-01-28 20:49 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28 19:46 Jeffrey Merkey
2016-01-28 19:56 ` Thomas Gleixner
2016-01-28 20:08   ` Jeffrey Merkey
2016-01-28 20:48     ` Thomas Gleixner [this message]
2016-01-28 20:58       ` Jeffrey Merkey
2016-01-28 22:06         ` Thomas Gleixner
2016-01-28 22:22           ` Jeffrey Merkey
2016-01-29  8:16         ` Ingo Molnar
2016-01-29 16:26           ` Jeffrey Merkey
2016-01-29 16:34           ` Jeffrey Merkey
2016-01-29 17:19             ` Jeffrey Merkey
2016-01-30  2:43           ` Jeffrey Merkey
2016-01-28 20:35 ` kbuild test robot
2016-01-28 20:41 ` Chris Metcalf
2016-01-28 20:48   ` Jeffrey Merkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1601282143110.3886@nanos \
    --to=tglx@linutronix.de \
    --cc=akpm@linux-foundation.org \
    --cc=atomlin@redhat.com \
    --cc=cmetcalf@ezchip.com \
    --cc=dzickus@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=hidehiro.kawai.ez@hitachi.com \
    --cc=jeffmerkey@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=tj@kernel.org \
    --cc=uobergfe@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®