From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754767AbcA2Ibr (ORCPT ); Fri, 29 Jan 2016 03:31:47 -0500 Received: from www.linutronix.de ([62.245.132.108]:49071 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754669AbcA2Ibq (ORCPT ); Fri, 29 Jan 2016 03:31:46 -0500 Date: Fri, 29 Jan 2016 09:30:41 +0100 (CET) From: Thomas Gleixner To: Shanker Donthineni cc: Marc Zyngier , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jason Cooper , Vikram Sethi Subject: Re: [PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables() In-Reply-To: <1454042578-13933-1-git-send-email-shankerd@codeaurora.org> Message-ID: References: <1454042578-13933-1-git-send-email-shankerd@codeaurora.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 28 Jan 2016, Shanker Donthineni wrote: > @@ -807,9 +810,10 @@ static void its_free_tables(struct its_node *its) > int i; > > for (i = 0; i < GITS_BASER_NR_REGS; i++) { > - if (its->tables[i]) { > - free_page((unsigned long)its->tables[i]); > - its->tables[i] = NULL; > + if (its->tables[i].base) { > + free_pages((unsigned long)its->tables[i].base, > + get_order(its->tables[i].size)); > + its->tables[i].base = NULL; > } > } > } > @@ -880,6 +884,7 @@ retry_alloc_baser: > if (alloc_pages > GITS_BASER_PAGES_MAX) { > alloc_pages = GITS_BASER_PAGES_MAX; > order = get_order(GITS_BASER_PAGES_MAX * psz); > + alloc_size = (1 << order) * PAGE_SIZE; Why don't you record the order instead of converting back and forth ? Thanks, tglx