From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755845AbcA2Iz7 (ORCPT <rfc822;w@1wt.eu>);
	Fri, 29 Jan 2016 03:55:59 -0500
Received: from www.linutronix.de ([62.245.132.108]:49727 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755778AbcA2Iz4 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 29 Jan 2016 03:55:56 -0500
Date: Fri, 29 Jan 2016 09:54:51 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: Oleksij Rempel <linux@rempel-privat.de>
cc: kernel@pengutronix.de, linux-kernel@vger.kernel.org, jason@lakedaemon.net,
        marc.zyngier@arm.com
Subject: Re: [PATCH] irqchip: mxs: add missing set_handle_irq()
In-Reply-To: <56AB2784.2090205@rempel-privat.de>
Message-ID: <alpine.DEB.2.11.1601290948550.3886@nanos>
References: <1454056195-23105-1-git-send-email-linux@rempel-privat.de> <alpine.DEB.2.11.1601290932250.3886@nanos> <56AB2784.2090205@rempel-privat.de>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> Am 29.01.2016 um 09:33 schrieb Thomas Gleixner:
> > On Fri, 29 Jan 2016, Oleksij Rempel wrote:
> > 
> >> this will fix IRQ related issues on Alphascale ASM9260
> > 
> > This really does not qualify as a changelog.
> > 
> > 1) What's the problem and what consequences does it have
> > 
> > 2) What's the fix.
> > 
> > Thanks,
> > 
> > 	tglx
> > 
> 
> The driver provide this function:
> asmlinkage void __exception_irq_entry icoll_handle_irq(struct pt_regs *regs)
> {
>         u32 irqnr;
> 
>         irqnr = __raw_readl(icoll_priv.stat);
>         __raw_writel(irqnr, icoll_priv.vector);
>         handle_domain_irq(icoll_domain, irqnr, regs);
> }
> 
> i assume at some late review point instead of move it to asm9260_of_init
> i removed it completely. As result, the driver was compilable but not
> working.
> Should i put this explanation to changelog?

So the problem is:

The rework of the driver missed to move the call to set_handle_irq() into
asm9260_of_init(). As a consequence no interrupt entry point is installed and
no interrupts are delivered (or whatever the outcome is, crash, explode ...)

Solution is:

Install the interrupt entry handler.

Right?

And that wants a tag:

Fixes: nnnnnnnnnnnn ("irqchip/......")

So we can mark it for stable.

Thanks,

	tglx