From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752366AbcBHKkD (ORCPT <rfc822;w@1wt.eu>);
	Mon, 8 Feb 2016 05:40:03 -0500
Received: from www.linutronix.de ([62.245.132.108]:57494 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751840AbcBHKkB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 8 Feb 2016 05:40:01 -0500
Date: Mon, 8 Feb 2016 11:38:43 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: David Daney <ddaney@caviumnetworks.com>
cc: David Daney <ddaney.cavm@gmail.com>, linux-mips@linux-mips.org,
        ralf@linux-mips.org, linux-kernel@vger.kernel.org,
        David Daney <david.daney@cavium.com>, Rob Herring <robh+dt@kernel.org>,
        Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>, devicetree@vger.kernel.org
Subject: Re: [PATCH 6/7] [PATCH] MIPS: OCTEON: Add support for OCTEON III
 interrupt controller.
In-Reply-To: <56B4DA3B.40607@caviumnetworks.com>
Message-ID: <alpine.DEB.2.11.1602081137460.25254@nanos>
References: <1454632974-7686-1-git-send-email-ddaney.cavm@gmail.com> <1454632974-7686-7-git-send-email-ddaney.cavm@gmail.com> <alpine.DEB.2.11.1602050954480.25254@nanos> <56B4DA3B.40607@caviumnetworks.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 5 Feb 2016, David Daney wrote:
> On 02/05/2016 01:06 AM, Thomas Gleixner wrote:
> > > +int octeon_irq_ciu3_xlat(struct irq_domain *d,
> > 
> > static ?
> 
> To be used in follow-on patch for MSI-X irq_chip driver residing in a separate
> file.
> 
> The idea was to not be changing the to/from static multiple times as the new
> patches were merged.  If you think it preferable, I can make them all static
> and then remove the static later, when needed.

Nah. It was just not clear from reading this patch. A hint in the changelog
might be helpful.
 
Thanks,

	tglx