From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964830AbcBIKyO (ORCPT ); Tue, 9 Feb 2016 05:54:14 -0500 Received: from www.linutronix.de ([62.245.132.108]:38994 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932562AbcBIKyL (ORCPT ); Tue, 9 Feb 2016 05:54:11 -0500 Date: Tue, 9 Feb 2016 11:52:56 +0100 (CET) From: Thomas Gleixner To: Ingo Molnar cc: Chen Yucong , hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/kernel: use pr_() and dev_ In-Reply-To: <20160209095749.GA2953@gmail.com> Message-ID: References: <1454666121-14972-1-git-send-email-slaoub@gmail.com> <20160209095749.GA2953@gmail.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 9 Feb 2016, Ingo Molnar wrote: > > * Chen Yucong wrote: > > > arch/x86/kernel/* use a mixture of printk(KERN_ ) and pr_(). > > This patch converts the bulk of printk(KERN_ ) to pr_() and > > uses dev_dbg() instead of the dev_printk(KERN_DEBUG,). All pr_warning() > > calls have been replaced with pr_warn(). > > > > Not sure what to do about the printk(KERN_DEFAULT) and printk() without a > > log level. > > > > Signed-off-by: Chen Yucong > > When converting please also join broken up format strings, such as: > > - printk(KERN_WARNING PREFIX > - "HPET id: %#x base: 0xfed0000000000000 fixed up " > - "to 0xfed00000.\n", hpet_tbl->id); > + pr_warn(PREFIX "HPET id: %#x base: 0xfed0000000000000 fixed up " > + "to 0xfed00000.\n", hpet_tbl->id); > > ignore checkpatch: we don't line-break user visible strings. And please get rid of PREFIX. define pr_fmt instead. Thanks, tglx