From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbcBKSuh (ORCPT ); Thu, 11 Feb 2016 13:50:37 -0500 Received: from www.linutronix.de ([62.245.132.108]:58457 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750917AbcBKSug (ORCPT ); Thu, 11 Feb 2016 13:50:36 -0500 Date: Thu, 11 Feb 2016 19:49:20 +0100 (CET) From: Thomas Gleixner To: Linus Torvalds cc: Tejun Heo , Linux Kernel Mailing List Subject: Re: [GIT PULL] workqueue fixes for v4.5-rc3 In-Reply-To: Message-ID: References: <20160210172502.GO3741@mtj.duckdns.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus, On Thu, 11 Feb 2016, Linus Torvalds wrote: > On Thu, Feb 11, 2016 at 12:18 AM, Thomas Gleixner wrote: > > > > That certainly makes sense. So we should use a common debug option to force > > the 'schedule remote' machinery for all interesting subsystems instead of > > creating an extra option for each. > > Yeah, let's make it easy to use and enable. > > If it was split, the options would likely interact anyway (ie any > option that enables "add_timer()" to run on arbitrary cpu's wouldl > automatically also affect "queue_delayed_work()"), so it's not like it > would really be truly independent issues anyway. > > And if it does show an oops or other problem due to some broken > expectations, I'd hope the oops should be enough to show what the > problem is. It did for the vmstat case. while playing around with it and wondering where to put the command line option, I wondered whether it makes sense to tie this to debugobjects. If stuff goes bad, then state corruptions of the involved objects (timers, work ..) are likely to happen, so having debugobjects enabled along with that force RR scheme makes a lot of sense. Thoughts? Thanks, tglx