From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424229AbcBQQNY (ORCPT ); Wed, 17 Feb 2016 11:13:24 -0500 Received: from www.linutronix.de ([62.245.132.108]:44757 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423618AbcBQQNV (ORCPT ); Wed, 17 Feb 2016 11:13:21 -0500 Date: Wed, 17 Feb 2016 17:12:04 +0100 (CET) From: Thomas Gleixner To: tchalamarla@caviumnetworks.com cc: tj@kernel.org, stripathi@apm.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH V3] AHCI: Workaround for ThunderX Errata#22536 In-Reply-To: <1455653329-4934-1-git-send-email-tchalamarla@caviumnetworks.com> Message-ID: References: <1455653329-4934-1-git-send-email-tchalamarla@caviumnetworks.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 16 Feb 2016, tchalamarla@caviumnetworks.com wrote: > +#ifdef CONFIG_ARM64 > +/* Due to ERRATA#22536, ThunderX need to handle > + * HOST_IRQ_STAT differently. > + * Work around is to make sure all pending IRQs > + * are served before leaving handler > + */ > +static irqreturn_t ahci_thunderx_irq_handler(int irq, void *dev_instance) > +{ > + struct ata_host *host = dev_instance; > + struct ahci_host_priv *hpriv; > + unsigned int rc = 0; > + void __iomem *mmio; > + u32 irq_stat, irq_masked; > + unsigned int handled = 1; > + > + VPRINTK("ENTER\n"); Come on. This VPRINK stuff is really pointless. Enable irq tracepoints, they already track the enter/exit of interrupt handlers .... Thanks, tglx