From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423349AbcBQTMc (ORCPT ); Wed, 17 Feb 2016 14:12:32 -0500 Received: from www.linutronix.de ([62.245.132.108]:45553 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964895AbcBQTMa (ORCPT ); Wed, 17 Feb 2016 14:12:30 -0500 Date: Wed, 17 Feb 2016 20:11:15 +0100 (CET) From: Thomas Gleixner To: Vikas Shivappa cc: Vikas Shivappa , x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, kanaka.d.juvva@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH V4 0/5] x86/mbm : Intel Memory Bandwidth monitoring support In-Reply-To: Message-ID: References: <1455152873-30467-1-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Vikas, On Wed, 17 Feb 2016, Vikas Shivappa wrote: > Was wondering if you had any feedback on the MBM patches. These are almost a > complete rewrite (the core part 3/5 from Tony Luck). The reused parts are > mostly the declarations of datastructures. This has tried to address all your > comments on V3 about the commenting, the core calculation, init, lot of > unnecessary and confusing constants and code.. It's on my list. I tend to it, when I cleaned up the unholy mess in perf_intel_* et al. Thanks, tglx