From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423642AbcBQWBV (ORCPT <rfc822;w@1wt.eu>);
	Wed, 17 Feb 2016 17:01:21 -0500
Received: from www.linutronix.de ([62.245.132.108]:46148 "EHLO
	Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S965392AbcBQWBU (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 17 Feb 2016 17:01:20 -0500
Date: Wed, 17 Feb 2016 23:00:04 +0100 (CET)
From: Thomas Gleixner <tglx@linutronix.de>
To: "Liang, Kan" <kan.liang@intel.com>
cc: LKML <linux-kernel@vger.kernel.org>, Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Stephane Eranian <eranian@google.com>,
        "Chegondi, Harish" <harish.chegondi@intel.com>,
        "Kleen, Andi" <andi.kleen@intel.com>
Subject: RE: [patch 04/11] x86/perf/intel_uncore: Cleanup hardware on exit
In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0770588B1D0@shsmsx102.ccr.corp.intel.com>
Message-ID: <alpine.DEB.2.11.1602172257320.19512@nanos>
References: <20160217132903.767990400@linutronix.de> <20160217133932.018288722@linutronix.de> <37D7C6CF3E00A74B8858931C1DB2F0770588AF38@shsmsx102.ccr.corp.intel.com> <alpine.DEB.2.11.1602171858000.19512@nanos>
 <37D7C6CF3E00A74B8858931C1DB2F0770588B1D0@shsmsx102.ccr.corp.intel.com>
User-Agent: Alpine 2.11 (DEB 23 2013-08-11)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
X-Linutronix-Spam-Score: -1.0
X-Linutronix-Spam-Level: -
X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required,  ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 17 Feb 2016, Liang, Kan wrote:
> > If there is a single instance of exit_box() in that patch which flips the wrong
> > bits, then please point it out with the proper reference in the manual and
> > not with such half baken statements as above.
> > 
> Sorry, I didn't make it clear.
> For the older server platforms like nhmex and client platforms like snb, I agree
> with you on nhmex_uncore_msr_exit_box and snb_uncore_imc_exit_box.
> 
> However, for newer server platforms (start from IVB server), we cannot write 0
> to rsv bit of BOX control registers. The behavior is undefined.
> The following codes may have issues.
> It looks we also write 0 to rsv bit in box_init. We may need to fix it.

Each platform can have its own init/exit callbacks or just omit them when not
needed. But we certainly want them for platforms where it is either needed
(i.e. undo ioremap) or makes sense from the hardware POV.

Thanks,

	tglx