From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755686AbcBXKho (ORCPT ); Wed, 24 Feb 2016 05:37:44 -0500 Received: from www.linutronix.de ([62.245.132.108]:46796 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751553AbcBXKhg (ORCPT ); Wed, 24 Feb 2016 05:37:36 -0500 Date: Wed, 24 Feb 2016 11:36:16 +0100 (CET) From: Thomas Gleixner To: Vikas Shivappa cc: vikas.shivappa@intel.com, x86@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, kanaka.d.juvva@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 5/5] x86/mbm: Add support for MBM counter overflow handling In-Reply-To: <1455152873-30467-6-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1455152873-30467-1-git-send-email-vikas.shivappa@linux.intel.com> <1455152873-30467-6-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 10 Feb 2016, Vikas Shivappa wrote: > +static enum hrtimer_restart mbm_hrtimer_handle(struct hrtimer *hrtimer) > +{ > + if (list_empty(&cache_groups)) > + goto out; > + > + list_for_each_entry(iter, &cache_groups, hw.cqm_groups_entry) { .... > + } > + } > + > +out: > + raw_spin_unlock_irqrestore(&cache_lock, flags); > + mutex_unlock(&cache_mutex); > + > + hrtimer_forward_now(hrtimer, ms_to_ktime(MBM_CTR_OVERFLOW_TIME)); > + > + return HRTIMER_RESTART; Why is that timer restarted if cache_groups is empty? Thanks, tglx