From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030270AbcBZSDf (ORCPT ); Fri, 26 Feb 2016 13:03:35 -0500 Received: from www.linutronix.de ([62.245.132.108]:32973 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754149AbcBZSDe (ORCPT ); Fri, 26 Feb 2016 13:03:34 -0500 Date: Fri, 26 Feb 2016 19:01:55 +0100 (CET) From: Thomas Gleixner To: Mathieu Desnoyers cc: Peter Zijlstra , Andrew Morton , Russell King , Ingo Molnar , "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-api , Paul Turner , Andrew Hunter , Andy Lutomirski , Andi Kleen , Dave Watson , Chris Lameter , Ben Maurer , rostedt , "Paul E. McKenney" , Josh Triplett , Catalin Marinas , Will Deacon , Michael Kerrisk , Linus Torvalds Subject: Re: [PATCH v4 1/5] getcpu_cache system call: cache CPU number of running thread In-Reply-To: <967083634.8940.1456507201156.JavaMail.zimbra@efficios.com> Message-ID: References: <1456270120-7560-1-git-send-email-mathieu.desnoyers@efficios.com> <1456270120-7560-2-git-send-email-mathieu.desnoyers@efficios.com> <20160225095635.GO6356@twins.programming.kicks-ass.net> <390571988.7745.1456419326288.JavaMail.zimbra@efficios.com> <20160225170416.GV6356@twins.programming.kicks-ass.net> <2135602720.7810.1456420671941.JavaMail.zimbra@efficios.com> <20160226113304.GA6356@twins.programming.kicks-ass.net> <967083634.8940.1456507201156.JavaMail.zimbra@efficios.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Feb 2016, Mathieu Desnoyers wrote: > ----- On Feb 26, 2016, at 11:29 AM, Thomas Gleixner tglx@linutronix.de wrote: > > Right. There is no point in having two calls and two update mechanisms for a > > very similar purpose. > > > > So let userspace have one struct where cpu/seq and whatever is required for > > rseq is located and flag at register time which parts of the struct need to be > > updated. > > If we put both cpu/seq/other in that structure, why not plan ahead and make > it extensible then ? > > That looks very much like the "Thread-local ABI" series I posted last year. > See https://lkml.org/lkml/2015/12/22/464 > > Here is why I ended up introducing the specialized "getcpu_cache" system call > rather than the "generic" system call (quote from the getcpu_cache changelog): > > Rationale for the getcpu_cache system call rather than the thread-local > ABI system call proposed earlier: > > Rather than doing a "generic" thread-local ABI, specialize this system > call for a cpu number cache only. Anyway, the thread-local ABI approach > would have required that we introduce "feature" flags, which would have > ended up reimplementing multiplexing of features on top of a system > call. It seems better to introduce one system call per feature instead. > > If everyone end up preferring that we introduce a system call that implements > many features at once, that's indeed something we can do, but I remember > being told in the past that this is generally a bad idea. It's a bad idea if you mix stuff which does not belong together, but if you have stuff which shares a substantial amount of things then it makes a lot of sense. Especially if it adds similar stuff into hotpathes. > For one thing, it would make the interface more cumbersome to deal with > from user-space in terms of feature detection: if we want to make this > interface extensible, in addition to check -1, errno=ENOSYS, userspace > would have to deal with a field containing the length of the structure > as expected by user-space and kernel, and feature flags to see the common > set of features supported by kernel and user-space. > > Having one system call per feature seems simpler to handle in terms of > feature availability detection from a userspace point of view. That might well be, but that does not justify two fastpath updates, two seperate pointers to handle, etc .... Thanks, tglx