From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752950AbcCBIGG (ORCPT ); Wed, 2 Mar 2016 03:06:06 -0500 Received: from www.linutronix.de ([62.245.132.108]:49720 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751144AbcCBIGE (ORCPT ); Wed, 2 Mar 2016 03:06:04 -0500 Date: Wed, 2 Mar 2016 09:04:41 +0100 (CET) From: Thomas Gleixner To: Vikas Shivappa cc: vikas.shivappa@intel.com, linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, mingo@kernel.org, peterz@infradead.org, ravi.v.shankar@intel.com, tony.luck@intel.com, fenghua.yu@intel.com, h.peter.anvin@intel.com Subject: Re: [PATCH 3/6] x86/mbm: Intel Memory B/W Monitoring enumeration and init In-Reply-To: <1456876108-28770-4-git-send-email-vikas.shivappa@linux.intel.com> Message-ID: References: <1456876108-28770-1-git-send-email-vikas.shivappa@linux.intel.com> <1456876108-28770-4-git-send-email-vikas.shivappa@linux.intel.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Mar 2016, Vikas Shivappa wrote: > @@ -1397,8 +1543,11 @@ static int __init intel_cqm_init(void) > __perf_cpu_notifier(intel_cqm_cpu_notifier); > out: > cpu_notifier_register_done(); > - if (ret) > + if (ret) { > + mbm_enabled = false; > + cqm_enabled = false; > kfree(str); Leaks mbm_local and mbm_total .... > + } > > return ret; > } > -- > 1.9.1 > >