From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754890AbcCBT7Q (ORCPT ); Wed, 2 Mar 2016 14:59:16 -0500 Received: from www.linutronix.de ([62.245.132.108]:54350 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754776AbcCBT7N (ORCPT ); Wed, 2 Mar 2016 14:59:13 -0500 Date: Wed, 2 Mar 2016 20:57:19 +0100 (CET) From: Thomas Gleixner To: Peter Zijlstra cc: rostedt@goodmis.org, riel@redhat.com, mingo@kernel.org, rafael.j.wysocki@intel.com, bigeasy@linutronix.de, arjan@linux.intel.com, rusty@rustcorp.com.au, torvalds@linux-foundation.org, hpa@zytor.com, srivatsa@mit.edu, pjt@google.com, tj@kernel.org, akpm@linux-foundation.org, oleg@redhat.com, linux-kernel@vger.kernel.org, paulmck@linux.vnet.ibm.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:smp/hotplug] cpu/hotplug: Make target state writeable In-Reply-To: <20160302124138.GF6357@twins.programming.kicks-ass.net> Message-ID: References: <20160226182341.022814799@linutronix.de> <20160302124138.GF6357@twins.programming.kicks-ass.net> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2 Mar 2016, Peter Zijlstra wrote: > On Tue, Mar 01, 2016 at 11:55:01AM -0800, tip-bot for Thomas Gleixner wrote: > > Commit-ID: 757c989b9994f51b42d6be1bd33c7c12d16a3ac7 > > Gitweb: http://git.kernel.org/tip/757c989b9994f51b42d6be1bd33c7c12d16a3ac7 > > Author: Thomas Gleixner > > AuthorDate: Fri, 26 Feb 2016 18:43:32 +0000 > > Committer: Thomas Gleixner > > CommitDate: Tue, 1 Mar 2016 20:36:55 +0100 > > > > cpu/hotplug: Make target state writeable > > > > Make it possible to write a target state to the per cpu state file, so we can > > switch between states. > > But you've marked nearly all of them cant_stop, so while this implements > the interface, its not really functional just yet, right? Yes, the current state is more or less wrapping the existing notifiers and stopping them is not a brilliant idea. I've tried and it exploded nicely in my face. The ones we convert over to the state machine will be stoppable and reversible. And at the end the notifiers will be gone and with them the can't stop stuff, except maybe for a few crucial points. Thanks, tglx