From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752013AbcCKKuV (ORCPT ); Fri, 11 Mar 2016 05:50:21 -0500 Received: from www.linutronix.de ([62.245.132.108]:36677 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751634AbcCKKuG (ORCPT ); Fri, 11 Mar 2016 05:50:06 -0500 Date: Fri, 11 Mar 2016 11:48:40 +0100 (CET) From: Thomas Gleixner To: Gregory CLEMENT cc: Anna-Maria Gleixner , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, rt@linutronix.de Subject: Re: [PATCH] net: mvneta: Add missing hotplug notifier transition In-Reply-To: <8737rx2tqw.fsf@free-electrons.com> Message-ID: References: <1457687423-39784-1-git-send-email-anna-maria@linutronix.de> <8737rx2tqw.fsf@free-electrons.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Gregory, On Fri, 11 Mar 2016, Gregory CLEMENT wrote: > On ven., mars 11 2016, Anna-Maria Gleixner wrote: > > > The mvneta_percpu_notifier() hotplug callback lacks handling of the > > CPU_DOWN_FAILED case. That means, if CPU_DOWN_PREPARE failes, the > > driver is not well configured on the CPU. > > > > Add handling for CPU_DOWN_FAILED[_FROZEN] hotplug notifier transition > > to setup the driver. > > I agree that we need to handle this case, however reusing CPU_ONLINE > case for it seems too much. Why is that too much? If it does the job, then it's definitely preferrable over an extra case for a non hotpath error handling operation. Thanks, tglx