mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Jianyu Zhan <nasa4836@gmail.com>
Cc: mingo@redhat.com, "H. Peter Anvin" <hpa@zytor.com>,
	Aravind.Gopalakrishnan@amd.com, brgerst@gmail.com, bp@suse.de,
	feng.wu@intel.com, jiang.liu@linux.intel.com,
	Tejun Heo <tj@kernel.org>,
	dvlasenk@redhat.com, penberg@cs.helsinki.fi,
	Yinghai Lu <yhlu.kernel@gmail.com>,
	andi@firstfloor.org, Andy Lutomirski <luto@kernel.org>,
	ajm@sgi.com, Yinghai Lu <yinghai@kernel.org>,
	Akinobu Mita <akinobu.mita@gmail.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on
Date: Sun, 13 Mar 2016 10:11:57 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.11.1603131007210.3657@nanos> (raw)
In-Reply-To: <CAHz2CGXUYs4aC5WKeekN3bUsr-r_nei6tLLFNSz9h2okmxAdfQ@mail.gmail.com>

On Sun, 13 Mar 2016, Jianyu Zhan wrote:
> On Sun, Mar 13, 2016 at 3:55 PM, Thomas Gleixner <tglx@linutronix.de> wrote:
> > if LOCAL_APIC is disabled it does not use the interrupt, simply because there
> > is no way to trigger it. That setup is inside #ifdef CONFIG_X86_LOCAL_APIC for
> > exactly that reason.
> >
> > Just because IRQ_WORK has no config dependency on LOCAL APIC that does not
> > mean it uses the interrupt gate unconditionally.
> >
> 
> Thanks for clarification.
> 
> I think IRQ_WORK works as generic hardirq context callbacks, it should reply on
> self IPI,  which is a functionality provided by LOCAL_APIC, while
> legacy PIC doesn't
> provide this(correct?).

As I said before IRQ_WORK can work w/o APIC. And therefor IRQ_WORK does NOT
depend on APIC.
 
End of story. Nothing to change here at all.

Thanks,

	tglx

  reply	other threads:[~2016-03-13  9:13 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-12 15:05 [PATCH 0/3] x86/irq: Refactor special vector definition and cleanup Jianyu Zhan
2016-03-12 15:06 ` [PATCH 1/3] x86/asm/irq: Rearrange definitoin of specical irq vectors " Jianyu Zhan
2016-03-12 15:10 ` [PATCH 2/3] x86/irq: refactor native_init_IRQ Jianyu Zhan
2016-03-12 15:30   ` kbuild test robot
2016-03-12 15:36     ` Jianyu Zhan
2016-03-12 16:25   ` kbuild test robot
2016-03-12 15:10 ` [PATCH 3/3] x86/irq: update first_system_vector only when X86_LOCAL_PIC is on Jianyu Zhan
2016-03-12 20:08   ` Thomas Gleixner
2016-03-13  1:28     ` Jianyu Zhan
2016-03-13  6:35       ` Thomas Gleixner
2016-03-13  7:25         ` Jianyu Zhan
2016-03-13  7:41           ` Jianyu Zhan
2016-03-13  7:55           ` Thomas Gleixner
2016-03-13  8:20             ` Jianyu Zhan
2016-03-13  9:11               ` Thomas Gleixner [this message]
2016-03-13  9:29                 ` Jianyu Zhan
2016-03-13  9:33                   ` Thomas Gleixner
2016-03-13 10:08                     ` Jianyu Zhan
2016-03-13 11:12                       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.11.1603131007210.3657@nanos \
    --to=tglx@linutronix.de \
    --cc=Aravind.Gopalakrishnan@amd.com \
    --cc=ajm@sgi.com \
    --cc=akinobu.mita@gmail.com \
    --cc=andi@firstfloor.org \
    --cc=bp@suse.de \
    --cc=brgerst@gmail.com \
    --cc=dvlasenk@redhat.com \
    --cc=feng.wu@intel.com \
    --cc=hpa@zytor.com \
    --cc=jiang.liu@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=nasa4836@gmail.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=tj@kernel.org \
    --cc=x86@kernel.org \
    --cc=yhlu.kernel@gmail.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®