From: Thomas Gleixner <tglx@linutronix.de>
To: Kan Liang <kan.liang@intel.com>
Cc: peterz@infradead.org, ak@linux.intel.com, eranian@google.com,
mingo@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular
Date: Fri, 18 Mar 2016 19:34:12 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.11.1603181932230.3978@nanos> (raw)
In-Reply-To: <1458298116-2610-1-git-send-email-kan.liang@intel.com>
On Fri, 18 Mar 2016, kan.liang@intel.com wrote:
> From: Kan Liang <kan.liang@intel.com>
>
> This patch makes Intel uncore pmu driver modular.
> By default, the uncore driver will be built in the kernel. If it is
> configured as module, the supported cpu model can be auto loaded.
> This patch also cleans up the code of cpu_init and pci_init.
Nice work!
> +static struct intel_uncore_init_fun skl_uncore_init = {
> + .pci_init = skl_uncore_pci_init,
> +};
> +
> +static const struct x86_cpu_id intel_uncore_match[] = {
Shouldn't all of these structs be const __initconst?
Other than that:
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
next prev parent reply other threads:[~2016-03-18 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 10:48 kan.liang
2016-03-18 10:48 ` [PATCH V2 2/2] x86/perf/intel/uncore: Make Intel rapl modular kan.liang
2016-03-18 18:38 ` Thomas Gleixner
2016-03-18 18:34 ` Thomas Gleixner [this message]
2016-03-18 18:51 ` [PATCH V2 1/2] x86/perf/intel/uncore: Make Intel uncore modular Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.11.1603181932230.3978@nanos \
--to=tglx@linutronix.de \
--cc=ak@linux.intel.com \
--cc=eranian@google.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®